lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Composite framework: Add suspended sysfs entry
On Wed, Apr 21, 2010 at 05:38:21PM +0200, fabien.chouteau@gmail.com wrote:
> From: Fabien Chouteau <fabien.chouteau@barco.com>
>
>
> Signed-off-by: Fabien Chouteau <fabien.chouteau@barco.com>
> ---
> drivers/usb/gadget/composite.c | 21 +++++++++++++++++++++
> include/linux/usb/composite.h | 1 +
> include/linux/usb/gadget.h | 4 ++++
> 3 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 09289bb..a5352f3 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -898,6 +898,18 @@ static void composite_disconnect(struct usb_gadget *gadget)
>
> /*-------------------------------------------------------------------------*/
>
> +static ssize_t composite_show_suspended(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)

As you added a sysfs file, it is required that you also add an entry in
Documentation/ABI/ that describes the file and what it is for. Please
respin this with that added to the patch.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-04-21 20:19    [W:0.083 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site