lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: RCU-isms in fs/nfs/delegation.c
    Date
    Trond Myklebust <Trond.Myklebust@netapp.com> wrote:

    > + nfs_inode_set_delegation(inode, cred, res);
    > + }
    > +out:
    > + rcu_read_unlock();
    > }

    I think this is wrong. nfs_inode_set_delegation() may sleep as it calls
    kmalloc() with GFP_KERNEL - but you still have the RCU read lock held. I
    think you need to drop the RCU read lock before calling it.

    David


    \
     
     \ /
      Last update: 2010-04-20 10:51    [W:2.762 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site