Messages in this thread | | | Date | Wed, 21 Apr 2010 10:02:02 +0800 | From | Li Yu <> | Subject | Re: A possible bug in reqsk_queue_hash_req() |
| |
Eric Dumazet 写道: > Le mardi 20 avril 2010 à 21:21 +0800, Li Yu a écrit : > >> In my word, write lock also means mutual exclusion among all writers, >> is it right? >> > > Yes, generally speaking. > > But not on this use case. > > This is documented in an include file, if you search for syn_wait_lock > >>> All callers of this reqsk_queue_hash_req() must have the socket locked >> See. If we always assumed the caller should hold the locked socket >> first, this is not a bug, but I think we'd better add a comment at >> header file. > > It is documented, as a matter of fact :) > >
Great, this isn't a bug, you are right here :)
I just found out these comments about syn_wait_lock, it seem that we need to crossed reference documents for kernel API, a newbie like me, may confused at such similar problems.
> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |