lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads
From
Date
On Tue, 2010-04-20 at 18:14 +0100, Matthew Garrett wrote:
> On Tue, Apr 20, 2010 at 11:56:41AM -0500, Jerone Young wrote:
> > Don't think this patch should go in as Lenovo is issuing a BIOS to
> > address this issue. On these Thinkpads listed and more. Seems to add
> > uneeded quirks in my opinion.
> >
> > Though some over all patch may be good for all machines. As Windows
> > seems to be setting this bit on it's own.
>
> It's a perfectly safe workaround that's limited to a well-bounded set of
> machines and fixes a pretty serious problem with them. While I'd prefer
> my approach and then a removal of the existing quirk entries, Alex's
> patch makes more sense for stable. The BIOS update is as yet unreleased,
> requires either Windows or an optical drive (which some of these
> machines don't have) and is a far from discoverable solution to the
> issue.

I could agree, but the only issue is if you go to the thinkpad-acpi or
ibm-acpi mailing list they would probably disagree as there have been
updates to the bios in the past required for proper functionality of
Thinkpads ;-) .. the bios update methods have not changed since then for
Thinkpads.

Thanks,
Jerone







\
 
 \ /
  Last update: 2010-04-20 19:21    [W:1.801 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site