lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] uml: Drop private round_down definition
    On Tue, Apr 20, 2010 at 04:33:58PM +0800, Amerigo Wang wrote:
    > On Mon, Apr 19, 2010 at 11:53:05PM +0200, Jan Kiszka wrote:
    > >Already defined in kernel.h. The official version assumes that 'n' is
    > >power of two - which it is in our case.
    > >
    > >Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
    > >---
    > > arch/um/sys-x86_64/signal.c | 2 --
    > > 1 files changed, 0 insertions(+), 2 deletions(-)
    > >
    > >diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signal.c
    > >index 1a899a7..07797d1 100644
    > >--- a/arch/um/sys-x86_64/signal.c
    > >+++ b/arch/um/sys-x86_64/signal.c
    > >@@ -165,8 +165,6 @@ struct rt_sigframe
    > > struct _fpstate fpstate;
    > > };
    > >
    > >-#define round_down(m, n) (((m) / (n)) * (n))
    > >-
    > > int setup_signal_stack_si(unsigned long stack_top, int sig,
    > > struct k_sigaction *ka, struct pt_regs * regs,
    > > siginfo_t *info, sigset_t *set)
    >
    > Shouldn't this signal.c #include <linux/kernel.h>?

    I agree - if this is going to depend on kernel.h, it should be
    explicitly included.

    Jeff


    \
     
     \ /
      Last update: 2010-04-20 16:31    [W:3.929 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site