lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFC tip/core/rcu 10/16] rcu: slim down rcutiny by removing rcu_scheduler_active and friends
Date
Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:

> +void rcu_scheduler_starting(void)
> +{
> + WARN_ON(nr_context_switches() > 0);
> + rcu_scheduler_active = 1;
> +}

Since rcu_scheduler_active is a global variable, does it make sense to make
this an inline function in the header file?

It looks decidedly odd in its own include file as you've done it. Wouldn't
the right way to do this be to split it into its own .c file and conditionally
compile it in the Makefile?

David


\
 
 \ /
  Last update: 2010-04-20 12:19    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site