[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH RFC tip/core/rcu 10/16] rcu: slim down rcutiny by removing rcu_scheduler_active and friends
    Paul E. McKenney <> wrote:

    > +void rcu_scheduler_starting(void)
    > +{
    > + WARN_ON(nr_context_switches() > 0);
    > + rcu_scheduler_active = 1;
    > +}

    Since rcu_scheduler_active is a global variable, does it make sense to make
    this an inline function in the header file?

    It looks decidedly odd in its own include file as you've done it. Wouldn't
    the right way to do this be to split it into its own .c file and conditionally
    compile it in the Makefile?


     \ /
      Last update: 2010-04-20 12:19    [W:0.026 / U:0.148 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site