Messages in this thread | | | Date | Tue, 20 Apr 2010 19:14:05 +0900 | Subject | Re: error at compaction (Re: mmotm 2010-04-15-14-42 uploaded | From | Minchan Kim <> |
| |
On Tue, Apr 20, 2010 at 6:58 PM, Mel Gorman <mel@csn.ul.ie> wrote: > On Tue, Apr 20, 2010 at 06:50:23PM +0900, Minchan Kim wrote: >> On Tue, Apr 20, 2010 at 5:44 PM, Mel Gorman <mel@csn.ul.ie> wrote: >> > On Tue, Apr 20, 2010 at 05:32:13PM +0900, Minchan Kim wrote: >> >> >> >> Yes. Then, Let's add comment like split_page. :) >> >> /* >> >> * Note: this is probably too low level an operation for use in drivers. >> >> * Please consult with lkml before using this in your driver. >> >> */ >> >> >> > >> > I can, but the comment that was there says it's like split_page except the >> > page is already free. This also covers not using it in a driver. >> >> I see. In addition, you already mentioned "As this is only being used >> for migration". >> I missed one. >> I don't have any against one. >> Will you repost v2 which move split_free_pages out of compaction.c? > > I don't understand your suggestion. split_free_pages is already out of > compaction.c.
Ahh. Sorry. It's my fault. I confused. forget it, please. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |