lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: error at compaction (Re: mmotm 2010-04-15-14-42 uploaded
    From
    On Tue, Apr 20, 2010 at 5:44 PM, Mel Gorman <mel@csn.ul.ie> wrote:
    > On Tue, Apr 20, 2010 at 05:32:13PM +0900, Minchan Kim wrote:
    >>
    >> Yes. Then, Let's add comment like split_page. :)
    >>  /*
    >>  * Note: this is probably too low level an operation for use in drivers.
    >>  * Please consult with lkml before using this in your driver.
    >>  */
    >>
    >
    > I can, but the comment that was there says it's like split_page except the
    > page is already free. This also covers not using it in a driver.

    I see. In addition, you already mentioned "As this is only being used
    for migration".
    I missed one.
    I don't have any against one.
    Will you repost v2 which move split_free_pages out of compaction.c?
    Anyway, feel free to add my reviewed-by sign.
    Thanks, Mel.

    Reviewed-by: Minchan Kim <minchan.kim@gmail.com>

    >
    > --
    > Mel Gorman
    > Part-time Phd Student                          Linux Technology Center
    > University of Limerick                         IBM Dublin Software Lab
    >



    --
    Kind regards,
    Minchan Kim
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-20 11:53    [W:0.039 / U:0.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site