lkml.org 
[lkml]   [2010]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] tty: release_one_tty() forgets to put pids
    On 04/02, Linus Torvalds wrote:
    >
    > On Fri, 2 Apr 2010, Oleg Nesterov wrote:
    > >
    > > release_one_tty(tty) can be called when tty still has a reference
    > > to pgrp/session. In this case we leak the pid.
    >
    > Hmm. Maybe we should have cleared this in tty_release() already. We
    > already do some of the session clearing there (but we clear the session in
    > the _tasks_ associated with the tty, not the tty session pointer).

    Yes, probably we can free them earlier.

    But I am very nervous about this change, I tried to defer put_pid()
    as much as possible, in case something else uses ->prgp/session
    before free_tty_struct().

    Oleg.



    \
     
     \ /
      Last update: 2010-04-02 20:47    [W:0.023 / U:1.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site