Messages in this thread | | | Date | Fri, 2 Apr 2010 14:17:54 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH 2/3] blkio: Add io controller stats like |
| |
On Thu, Apr 01, 2010 at 03:01:24PM -0700, Divyesh Shah wrote:
[..] > +#define GET_STAT(__VAR, __CONV) \ > +uint64_t get_##__VAR##_stat(struct blkio_group *blkg, int dummy) \ > +{ \ > + uint64_t data = blkg->stats.__VAR; \ > + if (__CONV) \ > + data = (uint64_t)jiffies_to_msecs(data) * NSEC_PER_MSEC;\ > + return data; \ > +} > +
Hi Divyesh,
I think now you are exporting blkio.time in ns instead of ms?
- First of all your are breaking ABI. - Secondly, how does that help. You are capturing all your slice used stats in ms. You already lost any ns granularity. What's the point in converting these to ns now? - Does user space software really need that fine grained accounting. If this information is used for charging purposes, isn't ms good enough.
Thanks Vivek
| |