lkml.org 
[lkml]   [2010]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/8] USB: gadget: __init and __exit tags removed
2010/4/19 Michał Nazarewicz:
> Are you referring to my previous patch by saying "then they get tweaked
> to support a semi-dynamic state"? Those were just a proposal which was never
> accepted and suggested to remove those tags all together.

i'm referring to the change that started triggering these section
mismatch warnings with 2.6.33. i dont recall seeing any such issues
with 2.6.28-2.6.32, and probably older as well.

>> sounds like the system is insufficiently flexible to meet the
>> realistic needs of different groups.
>
> Yes, I agree.  That's why in the first version I proposed the __usb_init,
> __usb_exit, etc. tags which could be customized prior to including
> composite related files.
>
> I would still go with that solution but it was considered, let me
> find the exact phrase, "Ick ick ick." :)

seems like __usbgadget_xxx would be better naming, but i'm not
interested in fighting to get the idea in general accepted

> What's more, I don't see any other (that is cleaner) solution which
> would allow flexibility so it seems what we can either choose
> a non-flexible solution proposed by this patch or an ugly solution
> proposed by my previous patch.

i dont have a problem with your current patch (since there are still
seciton mismatch warnings floating about that i imagine this is going
to fix), just with the general situation
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-04-19 10:05    [W:0.087 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site