Messages in this thread | | | Date | Mon, 19 Apr 2010 23:52:26 +0200 | From | Tilman Schmidt <> | Subject | Re: tip: origin tree build failure, [patch] fix isdn/gigaset build failure |
| |
Am 19.04.2010 20:14 schrieb Linus Torvalds: > Maybe add the #include <linux/sched.h> into gigaset.h, instead of > common.c?
Yes, that's the correct fix. Thanks a lot!
For the record, the cause of the build failure was my removal of #include <linux/usb.h> from gigaset.h, entailing the loss of one indirect inclusion of sched.h. There's another indirect inclusion of sched.h from gigaset.h via interrupt.h, hardirq.h and smp_lock.h, but that one only operates if CONFIG_PREEMPT is set. So the reason I did not see the build failure myself was that I only tested with CONFIG_PREEMPT=y.
> --- > drivers/isdn/gigaset/gigaset.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/isdn/gigaset/gigaset.h b/drivers/isdn/gigaset/gigaset.h > index d32efb6..05947f9 100644 > --- a/drivers/isdn/gigaset/gigaset.h > +++ b/drivers/isdn/gigaset/gigaset.h > @@ -20,6 +20,7 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include <linux/kernel.h> > +#include <linux/sched.h> > #include <linux/compiler.h> > #include <linux/types.h> > #include <linux/ctype.h>
Acked-by: Tilman Schmidt <tilman@imap.cc>
in case it still matters.
Thanks again, Tilman
-- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[unhandled content-type:application/pgp-signature] | |