lkml.org 
[lkml]   [2010]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: tip: origin tree build failure, [patch] fix isdn/gigaset build failure

    * David Miller <davem@davemloft.net> wrote:

    > From: Ingo Molnar <mingo@elte.hu>
    > Date: Mon, 19 Apr 2010 19:27:31 +0200
    >
    > > Introduced by commit b91ecb00 that got pushed out today. That change removed
    > > an implicit sched.h inclusion that came in via slab.h.
    > >
    > > The patch below fixes it by adding the sched.h dependency.
    >
    > Thanks Ingo, Linus please apply:
    >
    > Acked-by: David S. Miller <davem@davemloft.net>

    Note, i just found that my patch is not enough as we fail the build elsewhere as well:

    drivers/isdn/gigaset/proc.c:52: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
    drivers/isdn/gigaset/proc.c:52: error: (Each undeclared identifier is reported only once
    drivers/isdn/gigaset/proc.c:52: error: for each function it appears in.)
    drivers/isdn/gigaset/proc.c:52: error: implicit declaration of function 'schedule'
    drivers/isdn/gigaset/interface.c:49: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
    drivers/isdn/gigaset/interface.c:49: error: (Each undeclared identifier is reported only once
    drivers/isdn/gigaset/interface.c:49: error: for each function it appears in.)
    drivers/isdn/gigaset/interface.c:49: error: implicit declaration of function 'schedule'
    drivers/isdn/gigaset/interface.c:83: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
    drivers/isdn/gigaset/ev-layer.c:981: error: 'TASK_NORMAL' undeclared (first use in this function)
    drivers/isdn/gigaset/ev-layer.c:981: error: (Each undeclared identifier is reported only once
    drivers/isdn/gigaset/ev-layer.c:981: error: for each function it appears in.)
    drivers/isdn/gigaset/ev-layer.c:1001: error: 'TASK_NORMAL' undeclared (first use in this function)
    drivers/isdn/gigaset/ev-layer.c:1495: error: 'TASK_NORMAL' undeclared (first use in this function)

    i'd suggest a revert of b91ecb00 instead.

    Ingo


    \
     
     \ /
      Last update: 2010-04-19 20:07    [W:0.022 / U:31.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site