Messages in this thread Patch in this message | | | Date | Mon, 19 Apr 2010 19:27:31 +0200 | From | Ingo Molnar <> | Subject | tip: origin tree build failure, [patch] fix isdn/gigaset build failure |
| |
* David Miller <davem@davemloft.net> wrote:
> Tilman Schmidt (1): > gigaset: include cleanup cleanup > > drivers/isdn/gigaset/bas-gigaset.c | 5 ----- > drivers/isdn/gigaset/capi.c | 2 -- > drivers/isdn/gigaset/common.c | 2 -- > drivers/isdn/gigaset/gigaset.h | 2 +- > drivers/isdn/gigaset/i4l.c | 1 - > drivers/isdn/gigaset/interface.c | 1 - > drivers/isdn/gigaset/proc.c | 1 - > drivers/isdn/gigaset/ser-gigaset.c | 3 --- > drivers/isdn/gigaset/usb-gigaset.c | 4 ----
-tip testing triggered the following build failure (x86 allyesconfig):
drivers/isdn/gigaset/common.c: In function 'setflags': drivers/isdn/gigaset/common.c:99: error: implicit declaration of function 'set_current_state' drivers/isdn/gigaset/common.c:99: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/common.c:99: error: (Each undeclared identifier is reported only once drivers/isdn/gigaset/common.c:99: error: for each function it appears in.) drivers/isdn/gigaset/common.c:100: error: implicit declaration of function 'schedule_timeout' drivers/isdn/gigaset/common.c: In function 'cleanup_cs': drivers/isdn/gigaset/common.c:900: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/common.c: In function 'gigaset_start': drivers/isdn/gigaset/common.c:942: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/common.c:942: error: implicit declaration of function 'schedule' drivers/isdn/gigaset/common.c: In function 'gigaset_shutdown': drivers/isdn/gigaset/common.c:978: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/common.c: In function 'gigaset_stop': drivers/isdn/gigaset/common.c:1005: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) make[1]: *** [drivers/isdn/gigaset/common.o] Error 1 make: *** [drivers/isdn/gigaset/common.o] Error 2
Introduced by commit b91ecb00 that got pushed out today. That change removed an implicit sched.h inclusion that came in via slab.h.
The patch below fixes it by adding the sched.h dependency.
Ingo
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index f6f45f2..a3aa17f 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -16,6 +16,7 @@ #include "gigaset.h" #include <linux/module.h> #include <linux/moduleparam.h> +#include <linux/sched.h> /* Version Information */ #define DRIVER_AUTHOR "Hansjoerg Lipp <hjlipp@web.de>, Tilman Schmidt <tilman@imap.cc>, Stefan Eilers"
| |