Messages in this thread | | | Date | Sat, 17 Apr 2010 21:23:22 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH V4 1/2] perf & kvm: Enhance perf to collect KVM guest os statistics from host side |
| |
On 04/16/2010 10:34 AM, Zhang, Yanmin wrote: > Below is the kernel patch to enable perf to collect guest os statistics. > > Joerg, > > Would you like to add support on svm? I don't know the exact point to trigger > NMI to host with svm. > > See below code with vmx: > > + kvm_before_handle_nmi(&vmx->vcpu); > asm("int $2"); > + kvm_after_handle_nmi(&vmx->vcpu); > > Signed-off-by: Zhang Yanmin<yanmin_zhang@linux.intel.com> >
Can you please split it further?
Patch 1 introduces perf_register_guest_info_callbacks() and related. Ingo can merge this into a branch in tip.git. Patch 2 is just the kvm bits, I'll apply that after merging the branch with patch 1. Patch 3 adds the tools/perf changes.
This way perf development can continue on tip.git, and kvm development can continue on kvm.git, without the code bases diverging and requiring a merge later.
-- Do not meddle in the internals of kernels, for they are subtle and quick to panic.
| |