lkml.org 
[lkml]   [2010]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC] buffer_head: remove redundant test from wait_on_buffer
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    On 04/16/2010 05:51 PM, Andrew Morton wrote:
    > And while we're there...
    >
    > This might make reiserfs explode.
    > We can remove __wait_on_buffer() altogether now. For some strange reason
    > reiserfs calls __wait_on_buffer() directly. Maybe it's passing in
    > zero-ref buffers. If so, we'll get warnings now and shall need to look at
    > that.

    I don't think that's the case. I think reiserfs just calls
    __wait_on_buffer just to skip the duplicate buffer_locked() test since
    every call is in an "if buffer_locked()" block. I don't think it's
    passing in zero-ref buffers anywhere, and I'd prefer it to explode if it is.

    - -Jeff

    - --
    Jeff Mahoney
    SUSE Labs
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v2.0.15 (GNU/Linux)
    Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

    iEYEARECAAYFAkvI4lIACgkQLPWxlyuTD7Ju9wCgphZEI8r9jB+75PIxE4l/S/H+
    jlEAnR+vo57PB2ZH+PhTSoxWnQ9V74M3
    =bQAA
    -----END PGP SIGNATURE-----


    \
     
     \ /
      Last update: 2010-04-17 00:21    [W:0.021 / U:0.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site