lkml.org 
[lkml]   [2010]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: Add initial support for Thinkpad T410s HDA codec.
At Wed, 14 Apr 2010 23:42:04 +0200,
Jens Taprogge wrote:
>
> Dear ALSA Maintainers,
>
> attached please find a patch that adds support for at least the T410s
> HDA codec. Most likely it will also add support for the T410 and T510
> based models.
>
>
> The patch was derived from Ideapad support. Support for the laptop's and
> docking-station output connectors as well as the docking-station microphone
> connector and the laptops internal devices has been tested. Since it has been
> developed without a data-sheet available, support for digital outputs and the
> laptop's microphone input may well be incorrect.
>
> Microphone mute functionality is not included:
> The microphone mute button seems to be reported through thinkpad_acpi key
> 0000101b. The mute button LED seems to be wired to thinkpad_acpi led
> number 15.
>
> Please apply.
>
> Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>

Thanks, applied now. Just one fix I made in addition:

> @@ -2292,7 +2355,7 @@ static void cxt5066_set_mic_boost(struct hda_codec *codec)
> AC_VERB_SET_AMP_GAIN_MUTE,
> AC_AMP_SET_RIGHT | AC_AMP_SET_LEFT | AC_AMP_SET_OUTPUT |
> cxt5066_analog_mic_boost.items[spec->mic_boost].index);
> - if (spec->ideapad) {
> + if (spec->ideapad | spec->thinkpad) {

This should be a logical OR.


Takashi


\
 
 \ /
  Last update: 2010-04-15 09:17    [W:0.047 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site