lkml.org 
[lkml]   [2010]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 05/10] vmscan: Remove unnecessary temporary vars in do_try_to_free_pages
Date
> Remove temporary variable that is only used once and does not help
> clarify code.
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

> ---
> mm/vmscan.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 838ac8b..1ace7c6 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1685,13 +1685,12 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc)
> */
> static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> {
> - enum zone_type high_zoneidx = gfp_zone(sc->gfp_mask);
> struct zoneref *z;
> struct zone *zone;
>
> sc->all_unreclaimable = 1;
> - for_each_zone_zonelist_nodemask(zone, z, zonelist, high_zoneidx,
> - sc->nodemask) {
> + for_each_zone_zonelist_nodemask(zone, z, zonelist,
> + gfp_zone(sc->gfp_mask), sc->nodemask) {
> if (!populated_zone(zone))
> continue;
> /*
> @@ -1741,7 +1740,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> unsigned long lru_pages = 0;
> struct zoneref *z;
> struct zone *zone;
> - enum zone_type high_zoneidx = gfp_zone(sc->gfp_mask);
> unsigned long writeback_threshold;
>
> delayacct_freepages_start();
> @@ -1752,7 +1750,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> * mem_cgroup will not do shrink_slab.
> */
> if (scanning_global_lru(sc)) {
> - for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) {
> + for_each_zone_zonelist(zone, z, zonelist, gfp_zone(sc->gfp_mask)) {
>
> if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL))
> continue;
> --
> 1.6.5
>





\
 
 \ /
  Last update: 2010-04-16 04:51    [W:0.146 / U:1.736 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site