Messages in this thread | | | Date | Thu, 15 Apr 2010 08:12:00 +0200 | From | Andreas Herrmann <> | Subject | useless node/has_cpu sysfs attribute |
| |
Hi,
commit 99dcc3e5a94ed491fbef402831d8c0bbb267f995 (this_cpu: Page allocator conversion) removed the call
node_set_state(node, N_CPU); /* this node has a cpu */
(in fact process_zones() where this call happened was removed).
Thus the sysfs attribute /sys/devices/system/node/has_cpu doesn't show anything anymore.
Before this commit the attribute usually listed all nodes ("having a CPU") in the system, e.g.
worms linux # cat /sys/devices/system/node/has_cpu 0-7
This attribute never reflected any changes triggered by CPU hotplug. I.e. you could set all CPUs of a node offline but the node still was listed in this attribute. (because no hotplug notifiers exist that would call node_set_state(node, N_CPU)/node_clear_state(node,N_CPU)).
Do we need this attribute? Who relies on information from this attribute?
I think if we do not need the attribute we should remove it. But if there is use for it we need to fix it and make it CPU hotplug aware.
Opinions?
Thanks,
Andreas
PS: The attribute was introduced with commit bde631a51876f23e9bbdce43f02b7232502c151e (mm: add node states sysfs class attributeS)
| |