lkml.org 
[lkml]   [2010]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/6] change alloc function in pcpu_alloc_pages
    From
    Hi, Tejun.

    On Thu, Apr 15, 2010 at 8:39 AM, Tejun Heo <tj@kernel.org> wrote:
    > Hello,
    >
    > On 04/14/2010 12:48 AM, Mel Gorman wrote:
    >> and the mapping table on x86 at least is based on possible CPUs in
    >> init_cpu_to_node() leaves the mapping as 0 if the APIC is bad or the numa
    >> node is reported in apicid_to_node as -1. It would appear on power that
    >> the node will be 0 for possible CPUs as well.
    >>
    >> Hence, I believe this to be safe but a confirmation from Tejun would be
    >> nice. I would continue digging but this looks like an initialisation path
    >> so I'll move on to the next patch rather than spending more time.
    >
    > This being a pretty cold path, I don't really see much benefit in
    > converting it to alloc_pages_node_exact().  It ain't gonna make any
    > difference.  I'd rather stay with the safer / boring one unless
    > there's a pressing reason to convert.

    Actually, It's to weed out not-good API usage as well as some performance gain.
    But I don't think to need it strongly.
    Okay. Please keep in mind about this and correct it if you confirms it
    in future. :)

    >
    > Thanks.
    >
    > --
    > tejun
    >



    --
    Kind regards,
    Minchan Kim
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-15 03:33    [W:2.494 / U:1.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site