lkml.org 
[lkml]   [2010]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/6] change alloc function in pcpu_alloc_pages
    Hello,

    On 04/14/2010 12:48 AM, Mel Gorman wrote:
    > and the mapping table on x86 at least is based on possible CPUs in
    > init_cpu_to_node() leaves the mapping as 0 if the APIC is bad or the numa
    > node is reported in apicid_to_node as -1. It would appear on power that
    > the node will be 0 for possible CPUs as well.
    >
    > Hence, I believe this to be safe but a confirmation from Tejun would be
    > nice. I would continue digging but this looks like an initialisation path
    > so I'll move on to the next patch rather than spending more time.

    This being a pretty cold path, I don't really see much benefit in
    converting it to alloc_pages_node_exact(). It ain't gonna make any
    difference. I'd rather stay with the safer / boring one unless
    there's a pressing reason to convert.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2010-04-15 01:39    [W:0.050 / U:120.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site