Messages in this thread | | | Date | Wed, 14 Apr 2010 15:23:27 +0300 | Subject | Re: [PATCH 3/6] change alloc function in alloc_slab_page | From | Pekka Enberg <> |
| |
On Wed, Apr 14, 2010 at 3:18 AM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Wed, 14 Apr 2010 00:25:00 +0900 > Minchan Kim <minchan.kim@gmail.com> wrote: > >> alloc_slab_page never calls alloc_pages_node with -1. >> It means node's validity check is unnecessary. >> So we can use alloc_pages_exact_node instead of alloc_pages_node. >> It could avoid comparison and branch as 6484eb3e2a81807722 tried. >> >> Cc: Christoph Lameter <cl@linux-foundation.org> >> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Minchan, care to send a v2 with proper changelog and reviewed-by attributions?
| |