lkml.org 
[lkml]   [2010]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/3] [kidled]: introduce kidled.
    From
    Date
    Salman <sqazi@google.com> writes:
    > +
    > +static int proc_stats(struct ctl_table *table, int write,
    > + void __user *buffer, size_t *lenp, loff_t *ppos)
    > +{
    > + int ret;
    > + unsigned long stats[3];
    > + int cpu = (int)((long)table->extra1);
    > + struct ctl_table fake = {};
    > +
    > + if (write)
    > + return -EINVAL;
    > +
    > + fake.data = stats;
    > + fake.maxlen = 3*sizeof(unsigned long);
    > +
    > + ret = smp_call_function_single(cpu, getstats, &stats, 1);
    > + if (ret)
    > + return ret;

    Haven't read the whole thing, but do any of these stats really
    need to execute on the target CPU? They seem to be just readable
    fields.

    Or does it simply not matter because this proc call is too infrequent?

    Anyways global broadcasts are discouraged, there is typically
    always someone who feels their RT latency be messed up by them.

    -Andi


    --
    ak@linux.intel.com -- Speaking for myself only.


    \
     
     \ /
      Last update: 2010-04-14 11:53    [W:2.525 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site