lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/6] change alloc function in alloc_slab_page
    From
    On Wed, Apr 14, 2010 at 6:37 AM, David Rientjes <rientjes@google.com> wrote:
    > On Wed, 14 Apr 2010, Minchan Kim wrote:
    >
    >> alloc_slab_page never calls alloc_pages_node with -1.
    >> It means node's validity check is unnecessary.
    >> So we can use alloc_pages_exact_node instead of alloc_pages_node.
    >> It could avoid comparison and branch as 6484eb3e2a81807722 tried.
    >>
    >> Cc: Christoph Lameter <cl@linux-foundation.org>
    >> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
    >> ---
    >>  mm/slub.c |    2 +-
    >>  1 files changed, 1 insertions(+), 1 deletions(-)
    >>
    >> diff --git a/mm/slub.c b/mm/slub.c
    >> index b364844..9984165 100644
    >> --- a/mm/slub.c
    >> +++ b/mm/slub.c
    >> @@ -1084,7 +1084,7 @@ static inline struct page *alloc_slab_page(gfp_t flags, int node,
    >>       if (node == -1)
    >>               return alloc_pages(flags, order);
    >>       else
    >> -             return alloc_pages_node(node, flags, order);
    >> +             return alloc_pages_exact_node(node, flags, order);
    >>  }
    >>
    >>  static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
    >
    > Slub changes need to go through its maintainer, Pekka Enberg
    > <penberg@cs.helsinki.fi>.

    Thanks, David. It was by mistake.

    Pekka.

    This changlog is bad.
    I will change it with following as when I send v2.

    "alloc_slab_page always checks nid == -1, so alloc_page_node can't be
    called with -1.
    It means node's validity check in alloc_pages_node is unnecessary.
    So we can use alloc_pages_exact_node instead of alloc_pages_node.
    It could avoid comparison and branch as 6484eb3e2a81807722 tried."

    Thanks.


    --
    Kind regards,
    Minchan Kim
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-14 01:43    [W:0.028 / U:1.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site