lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/6] change alloc function in alloc_slab_page
    Date
    alloc_slab_page never calls alloc_pages_node with -1.
    It means node's validity check is unnecessary.
    So we can use alloc_pages_exact_node instead of alloc_pages_node.
    It could avoid comparison and branch as 6484eb3e2a81807722 tried.

    Cc: Christoph Lameter <cl@linux-foundation.org>
    Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
    ---
    mm/slub.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/mm/slub.c b/mm/slub.c
    index b364844..9984165 100644
    --- a/mm/slub.c
    +++ b/mm/slub.c
    @@ -1084,7 +1084,7 @@ static inline struct page *alloc_slab_page(gfp_t flags, int node,
    if (node == -1)
    return alloc_pages(flags, order);
    else
    - return alloc_pages_node(node, flags, order);
    + return alloc_pages_exact_node(node, flags, order);
    }

    static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
    --
    1.7.0.5


    \
     
     \ /
      Last update: 2010-04-13 17:31    [W:0.022 / U:1.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site