lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 13 Apr 2010 12:01:37 -0300
FromMarcelo Tosatti <>
SubjectRe: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync
On Tue, Apr 13, 2010 at 09:53:07AM +0800, Xiao Guangrong wrote:
>
>
> Marcelo Tosatti wrote:
>
> > Xiao,
> >
> > Did you actually see this codepath as being performance sensitive?
>
> Actually, i not run benchmarks to contrast the performance before this patch
> and after this patch.
>
> >
> > I'd prefer to not touch it.
>
> This patch avoids walk all parents and i think this overload is really unnecessary.
> It has other tricks in this codepath but i not noticed? :-)

My point is that there is no point in optimizing something unless its
performance sensitive. And as i recall, mmu_unsync_walk was much more
sensitive performance wise than parent walking. Actually, gfn_to_memslot
seems more important since its also noticeable on EPT/NPT hosts.



\
 
 \ /
  Last update: 2010-04-13 17:17    [from the cache]
©2003-2010