lkml.org 
[lkml]   [2010]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync
    On 04/12/2010 11:02 AM, Xiao Guangrong wrote:
    > - 'vcpu' is not used while mark parent unsync, so remove it
    > - if it has alread marked unsync, no need to walk it's parent
    >
    >

    Please separate these two changes.

    The optimization looks good. Perhaps it can be done even nicer using
    mutually recursive functions (mmu_parent_walk calls mmu_parent_walk_fn
    which calls mmu_parent_walk on the parent), but let's not change too
    many things at a time.

    --
    I have a truly marvellous patch that fixes the bug which this
    signature is too narrow to contain.



    \
     
     \ /
      Last update: 2010-04-12 10:35    [W:4.141 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site