Messages in this thread | | | Date | Mon, 12 Apr 2010 11:32:53 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync |
| |
On 04/12/2010 11:02 AM, Xiao Guangrong wrote: > - 'vcpu' is not used while mark parent unsync, so remove it > - if it has alread marked unsync, no need to walk it's parent > >
Please separate these two changes.
The optimization looks good. Perhaps it can be done even nicer using mutually recursive functions (mmu_parent_walk calls mmu_parent_walk_fn which calls mmu_parent_walk on the parent), but let's not change too many things at a time.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| |