Messages in this thread | | | Date | Tue, 13 Apr 2010 09:34:14 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 2/6] KVM MMU: fix kvm_mmu_zap_page() and its calling path |
| |
Marcelo Tosatti wrote:
>> @@ -1483,8 +1483,8 @@ static int mmu_zap_unsync_children(struct kvm *kvm, >> for_each_sp(pages, sp, parents, i) { >> kvm_mmu_zap_page(kvm, sp); >> mmu_pages_clear_parents(&parents); >> + zapped++; >> } >> - zapped += pages.nr; >> kvm_mmu_pages_init(parent, &parents, &pages); >> } > > Don't see why this is needed? The for_each_sp loop uses pvec.nr.
I think mmu_zap_unsync_children() should return the number of zapped pages then we can adjust the number of free pages in kvm_mmu_change_mmu_pages(), but pages.nr no only includes the unsync/zapped pages but also includes their parents.
Thanks, Xiao
| |