Messages in this thread | | | Date | Thu, 1 Apr 2010 15:03:26 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH -v2] ibft, x86: Change reserve_ibft_region() to find_ibft_region() |
| |
On Thu, 1 Apr 2010 15:00:05 -0700 Yinghai Lu wrote:
> On Thu, Apr 1, 2010 at 2:54 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: > > On Thu, 01 Apr 2010 14:32:43 -0700 Yinghai Lu wrote: > > > >> > >> > >> So arch code could decide the way to reserve the ibft. > >> > >> And We should reserve ibft as early as possible, instead of BOOTMEM stage, > >> in case the table is in RAM range and is not reserved by BIOS. > >> > >> move that just sfter find_smp_config() > >> > >> Also when CONFIG_NO_BOOTMEM=y, We will not have reserve_bootmem() anymorea > >> > >> -v2: fix typo about ibft pointed by Konrad Rzeszutek Wilk <konrad@darnok.org> > > > > > >> Signed-off-by: Yinghai Lu <yinghai@kernel.org> > >> Cc: Pekka Enberg <penberg@cs.helsinki.fi> > >> Cc: Peter Jones <pjones@redhat.com> > >> Cc: Konrad Rzeszutek Wilk <konrad@kernel.org> > >> CC: Jan Beulich <jbeulich@novell.com> > >> > >> --- > >> arch/x86/kernel/setup.c | 14 ++++++++++++-- > >> drivers/firmware/iscsi_ibft_find.c | 11 ++++++++--- > >> include/linux/iscsi_ibft.h | 8 ++++++-- > >> 3 files changed, 26 insertions(+), 7 deletions(-) > >> > >> Index: linux-2.6/arch/x86/kernel/setup.c > >> =================================================================== > >> --- linux-2.6.orig/arch/x86/kernel/setup.c > >> +++ linux-2.6/arch/x86/kernel/setup.c > >> @@ -608,6 +608,16 @@ static int __init setup_elfcorehdr(char > >> early_param("elfcorehdr", setup_elfcorehdr); > >> #endif > >> > >> +static __init void reserve_ibft_region(void) > >> +{ > >> + unsigned long addr, size = 0; > >> + > >> + addr = find_ibft_region(&size); > >> + > >> + if (size) > >> + reserve_early_overlap_ok(addr, addr + size, "ibft"); > > > > where is the correction? > > -v1 has > > + if (size) > + reserve_early_overlap_ok(addr, addr + size, "ifbt");
Thanks. My eyes are blurry. ;)
--- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |