lkml.org 
[lkml]   [2010]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] input: remove BKL from mousedev
    Date
    There's no need for BKL in mousedev. It uses lots of locking already
    that should handle the open case.

    Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
    ---
    drivers/input/mousedev.c | 6 ------
    1 files changed, 0 insertions(+), 6 deletions(-)

    diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
    index a13d80f..f34b22b 100644
    --- a/drivers/input/mousedev.c
    +++ b/drivers/input/mousedev.c
    @@ -15,7 +15,6 @@

    #include <linux/sched.h>
    #include <linux/slab.h>
    -#include <linux/smp_lock.h>
    #include <linux/poll.h>
    #include <linux/module.h>
    #include <linux/init.h>
    @@ -542,10 +541,8 @@ static int mousedev_open(struct inode *inode, struct file *file)
    if (i >= MOUSEDEV_MINORS)
    return -ENODEV;

    - lock_kernel();
    error = mutex_lock_interruptible(&mousedev_table_mutex);
    if (error) {
    - unlock_kernel();
    return error;
    }
    mousedev = mousedev_table[i];
    @@ -554,7 +551,6 @@ static int mousedev_open(struct inode *inode, struct file *file)
    mutex_unlock(&mousedev_table_mutex);

    if (!mousedev) {
    - unlock_kernel();
    return -ENODEV;
    }

    @@ -575,7 +571,6 @@ static int mousedev_open(struct inode *inode, struct file *file)
    goto err_free_client;

    file->private_data = client;
    - unlock_kernel();
    return 0;

    err_free_client:
    @@ -583,7 +578,6 @@ static int mousedev_open(struct inode *inode, struct file *file)
    kfree(client);
    err_put_mousedev:
    put_device(&mousedev->dev);
    - unlock_kernel();
    return error;
    }

    --
    1.6.6.1


    \
     
     \ /
      Last update: 2010-03-09 20:23    [W:0.020 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site