lkml.org 
[lkml]   [2010]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Regulators: lp3971 - Fix setting val for LDO2 and LDO4
    On Tue, Mar 09, 2010 at 05:14:53PM +0800, axel lin wrote:
    > From 4e4c5f8267a4fbf651b4cc26c5f72465514f6224 Mon Sep 17 00:00:00 2001
    > From: Axel Lin <axel.lin@gmail.com>
    > Date: Tue, 9 Mar 2010 16:53:59 +0800
    > Subject: [PATCH] lp3971: Fix setting val for LDO2 and LDO4

    Please try to follow the instructions for submitting patches in
    Documentation/SubmittingPatches - this is missing Signed-off-by and CCs
    to maintainers.

    > In lp3971_ldo_set_voltage function, it requires val to left shift 4
    > bits for LDO2 and LDO4.
    > This patch fix this issue.

    CCing in the folks who worked with the hardware for confirmation - the
    patch looks OK to me but it's surprising that this wasn't noticed when
    the driver was being developed, it might be that the chip is doing
    something strange here.

    > ---
    > drivers/regulator/lp3971.c | 3 ++-
    > 1 files changed, 2 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
    > index f5532ed..a28ae37 100644
    > --- a/drivers/regulator/lp3971.c
    > +++ b/drivers/regulator/lp3971.c
    > @@ -187,7 +187,8 @@ static int lp3971_ldo_set_voltage(struct regulator_dev *dev,
    > return -EINVAL;
    >
    > return lp3971_set_bits(lp3971, LP3971_LDO_VOL_CONTR_REG(ldo),
    > - LDO_VOL_CONTR_MASK << LDO_VOL_CONTR_SHIFT(ldo), val);
    > + LDO_VOL_CONTR_MASK << LDO_VOL_CONTR_SHIFT(ldo),
    > + val << LDO_VOL_CONTR_SHIFT(ldo));
    > }
    >
    > static struct regulator_ops lp3971_ldo_ops = {


    \
     
     \ /
      Last update: 2010-03-09 15:29    [W:0.028 / U:62.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site