Messages in this thread | | | Subject | Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver | From | Johannes Berg <> | Date | Mon, 08 Mar 2010 08:41:57 +0100 |
| |
On Fri, 2010-03-05 at 11:47 -0800, Vadim Zaliva wrote: > This small patch is fixing an integer overflow issue in 'appletouch' driver. > > In particular, reading data from Geyser 2 touchpads used on post Oct > 2005 Apple PowerBooks the driver was casting X and Y coordinates > values to 'signed char'. Testing on one of such PowerBooks I have > noticed that touchpad always generates positive values, but some of > them are greater that 127, and thus, when cast to 'signed char' being > interpreted as a negative. > > Such bigger values have been observed infrequently, closer to the > edges of a touchpad, so the problem was not very visible. > Nevertheless, the patch would potentially improve touchpad > driver accuracy.
Hmm, you're probably right, and I cannot test with my powerbook as I'm about to leave on travel and it's at my parents.
johannes
| |