lkml.org 
[lkml]   [2010]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH,RESEND -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init()
    Date
    Oleg Nesterov <oleg@redhat.com> wrote:

    > (on top of kmod-replace-call_usermodehelper_pipe-with-use-of-umh-init-function-and-resolve-limit.patch)
    >
    > call_usermodehelper_keys() uses call_usermodehelper_setkeys() to change
    > subprocess_info->cred in advance. Now that we have info->init() we can
    > change this code to set tgcred->session_keyring in context of execing
    > kernel thread.
    >
    > Note: since currently call_usermodehelper_keys() is never called with
    > UMH_NO_WAIT, call_usermodehelper_keys()->key_get() and umh_keys_cleanup()
    > are not really needed, we could rely on install_session_keyring_to_cred()
    > which does key_get() on success.
    >
    > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    > Acked-by: Neil Horman <nhorman@tuxdriver.com>

    Acked-by: David Howells <dhowells@redhat.com>


    \
     
     \ /
      Last update: 2010-03-08 14:23    [W:0.039 / U:0.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site