Messages in this thread | | | Date | Mon, 8 Mar 2010 20:48:36 +0900 | From | Paul Mundt <> | Subject | Re: [GIT PULL] MFD update for 2.6.34 |
| |
On Sun, Mar 07, 2010 at 10:53:25PM +0100, Samuel Ortiz wrote: > H Hartley Sweeten (3): > mfd: Use resource_size() in sm501 > mfd: Use resource_size() for t7l66xb > mfd: Use resouce_size for tc6393xb > These need to be looked at carefully, at least the sm501 change is totally bogus, breaks everything, and stems from a total lack of understanding of how the drivers interact.
The I/O resource that's remapped and handled by the MFD takes the full size, while the region request is purposely trimmed down so only the registers needed by the MFD driver are reserved by the MFD driver. Other drivers (like sm501fb) will have their own region requests within the same resource at different offsets, all of which are broken after this change.
As such, 311e54c07e784fe63d421f724dcc597d1f82ccad at least needs to be reverted. I haven't looked at the other two, but if it's a similar mechanical change then those should be dropped, too.
| |