lkml.org 
[lkml]   [2010]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec
    Date
    On Monday 08 March 2010 12:34:52 Cyrill Gorcunov wrote:
    > On Mon, Mar 08, 2010 at 12:17:10PM +0100, Thomas Renninger wrote:
    > ...
    > > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
    > > index 3987e44..93cdb2a 100644
    > > + if (cpu_has_tsc)
    > > + rdtscll(ntsc);
    >
    > Perhaps rdtscll(tsc)?
    Oh dear..., I played with this to wipe out:
    warning: ‘tsc’ may be used uninitialized in this function

    > > + if (cpu_has_tsc) {
    > > + rdtscll(ntsc);
    > > + max_loops = (cpu_khz << 10) - (ntsc - tsc);
    >
    > Where is tsc modified? It remains tsc = 0 all the time?
    > Or I miss the snippet where it is set?
    Yes, you are right..., next version, thanks a lot for looking at this,

    Thomas
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-08 12:43    [W:0.019 / U:62.844 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site