lkml.org 
[lkml]   [2010]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] joystick: off by one error
    On Sat, Mar 06, 2010 at 02:09:44PM +0300, Dan Carpenter wrote:
    > This fixes a smatch warning:
    > drivers/input/joystick/gamecon.c +838 gc_setup_pad(23) error: buffer overflow 'gc_names' 10 <= 10
    >

    Crap. I already sent this patch. I'm really sorry about that.

    I will fix my QC process to not do this again.

    regards,
    dan carpenter

    > Signed-off-by: Dan Carpenter <error27@gmail.com>
    >
    > diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c
    > index ae998d9..7a55714 100644
    > --- a/drivers/input/joystick/gamecon.c
    > +++ b/drivers/input/joystick/gamecon.c
    > @@ -819,7 +819,7 @@ static int __init gc_setup_pad(struct gc *gc, int idx, int pad_type)
    > int i;
    > int err;
    >
    > - if (pad_type < 1 || pad_type > GC_MAX) {
    > + if (pad_type < 1 || pad_type >= GC_MAX) {
    > pr_err("Pad type %d unknown\n", pad_type);
    > return -EINVAL;
    > }


    \
     
     \ /
      Last update: 2010-03-06 12:41    [W:0.022 / U:1.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site