lkml.org 
[lkml]   [2010]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier
On Fri, Mar 05, 2010 at 11:59:18AM -0800, Andrew Morton wrote:
[...]
> > > /**
> > > * gpiochip_add() - register a gpio_chip
> > > * @chip: the chip to register, with chip->base initialized
> > > @@ -1103,6 +1107,9 @@ fail:
> > > pr_err("gpiochip_add: gpios %d..%d (%s) not registered\n",
> > > chip->base, chip->base + chip->ngpio - 1,
> > > chip->label ? : "generic");
> > > + else
> > > + blocking_notifier_call_chain(&gpio_notifier,
> > > + GPIO_NOTIFY_CHIP_ADDED, chip);
> >
> > Rather than doing an else block which will need to be reworked if/when
> > any additional code is added to the bottom of this routine, please
> > rework the if() block to bail on failure instead of implicitly falling
> > through to the return statement.
>
> This still hasn't happened.

It's in your tree already :-)

gpiolib-cosmetic-improvements-for-error-handling-in-gpiochip_add.patch

--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2


\
 
 \ /
  Last update: 2010-03-05 21:33    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site