Messages in this thread | | | Date | Thu, 4 Mar 2010 20:08:55 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 06/12] genericirq: make irq_chip related function to take desc |
| |
On Thu, 4 Mar 2010, Yinghai Lu wrote: > On 03/04/2010 06:31 AM, Thomas Gleixner wrote: > > The code which uses the chip functions needs to be changed: > > > > - desc->chip->fun(irq); > > + desc->chip->fun(desc); > > > > That's mostly in kernel/irq/* but there are some users in arch/* > > lowlevel irq handling code as well. > > that is our -v2 version.
I know, but the difference is that it is done by a machine.
I have been involved in more than one large scale overhaul projects in the kernel and most of the time I spent on those was to figure out the right way to do it to limit the risks.
Automated conversion is the best thing you can do and if Julia can whip up that rules, I'm less worried about the wholesale switchover on a per function basis, than I'm scared about the fully manual approach you took.
Thanks,
tglx
| |