lkml.org 
[lkml]   [2010]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] perf_events: add sampling period randomization support (v2)

    * eranian@google.com <eranian@google.com> wrote:

    > This patch adds support for randomizing the sampling period. Randomization
    > is very useful to mitigate the bias that exists with sampling. The random
    > number generator does not need to be sophisticated. This patch uses the
    > builtin random32() generator.

    > + if (width > 63 || attr->freq)
    > + return -EINVAL;

    Why not for freq counters? Those are semi-randomized already, but it might
    make sense to make them 'more' randomized in special circumstances. That would
    also allow us to enable the randomization in perf top and perf record, by
    default.

    Without that we'd have no immediate usecase and no way to ensure that this
    code works as intended.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2010-03-04 18:21    [W:0.068 / U:0.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site