lkml.org 
[lkml]   [2010]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC 7/9] ppp: use big tty mutex
    Date
    On Wednesday 31 March 2010 06:37:12 Américo Wang wrote:
    > > @@ -362,7 +362,8 @@ static const int npindex_to_ethertype[NUM_NP] = {
    > > */
    > > static int ppp_open(struct inode *inode, struct file *file)
    > > {
    > > - cycle_kernel_lock();
    > > + tty_lock();
    > > + tty_unlock();
    >
    > I don't really get your point here. :) Why do you do this?

    This is a blind conversion of the API from the common BKL functions to
    the TTY lock functions. There is no cycle_tty_lock(), so I'm manually
    doing the cycle.

    The reason why cycle_kernel_lock() was introduced in the first place
    is that some drivers may depend on the open() function not returning
    while another CPU holds the BKL. I did not feel qualified (or motivated)
    to determine if the ppp code has the behavior, so I left it at this.

    Arnd
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-31 09:41    [W:0.022 / U:30.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site