Messages in this thread | | | Date | Wed, 31 Mar 2010 09:05:48 +0200 | From | Dominik Brodowski <> | Subject | Re: [PATCH] net/pcmcia 3com: replacements of printk() with dev_info() and friends (fwd) |
| |
Hey,
On Tue, Mar 30, 2010 at 09:01:41PM +0400, Alexander Kurz wrote: > I wrote a patch as suggested by kernel-janitors. > It is my first patch, so I highly welcome comments and hints, > thanks, Alexander Kurz > > ---------- Forwarded message ---------- > Date: Tue, 30 Mar 2010 18:55:33 +0400 (MSD) > From: Alexander Kurz <akurz@blala.de> > To: kernel-janitors@vger.kernel.org > Subject: [PATCH] net/pcmcia 3com: replacements of printk() with dev_info() > and > friends > > Hello List, > I wrote a patch replacing some printk() with dev_info() and friends > for 3com 16-bit PCMCIA cards. > As this is my first linux patch, comments are welcome, > thanks, Alexander Kurz > > ---------- Forwarded message ---------- > Date: Tue, 30 Mar 2010 18:51:43 +0400 > From: Alexander Kurz <akurz@blala.de> > To: akurz@blala.de > > >From 84616314b126b730528ca10e704d80eabad96ff8 Mon Sep 17 00:00:00 2001 > From: Alexander Kurz <akurz@kbdbabel.org> > Date: Tue, 30 Mar 2010 12:08:54 +0200 > Subject: [PATCH] net/pcmcia 3com: replacements of printk() with dev_info() > and friends > as suggested by kernel-janitors for 3com 16-bit PCMCIA cards
that's two "forwarded message" messages too much :) Other than that, the only issue I see is that there's a "Signed-off-by"-Line missing. See Documentation/SubmittingPatches for details.
Best, Dominik
| |