lkml.org 
[lkml]   [2010]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Config NO_BOOTMEM breaks my amd64 box
On 03/31/2010 03:47 PM, Yinghai Lu wrote:
>>
>> Well and that whole #ifdeffery is disgusting as well - even if the goal was to
>> remove CONFIG_NO_BOOTMEM ASAP.
>>
>> Please learn to use proper intermediate helper functions and at minimum put
>> the conversion ugliness somewhere that doesnt intrude our daily flow in .c
>> files. The best rule is to _never ever_ put an #ifdef construct into a .c
>> file. It doesnt matter what the goal if the #ifdef is - such ugliness in code
>> is never justified.
>
> if you agree that i can have one nobootmem.c in mm/
>

That would be better, or more commonly, use inlines.

I'm still totally puzzled about this patch as well as the comment:

+#if defined(CONFIG_NO_BOOTMEM) && defined(MAX_NUMNODES)
+ /* In case some 32bit systems don't have RAM installed on node0 */
+ totalram_pages += free_all_memory_core_early(MAX_NUMNODES);
+#else
totalram_pages += free_all_bootmem();
+#endif


Why is that "32 bits" specific? Second, MAX_NUMNODES is defined
whenever <linux/numa.h> is included, so what on Earth is this supposed
to signify? Are you trying to say MAX_NUMNODES > 1? Or are you trying
to say CONFIG_NUMA?

Furthermore, I really don't see the connection between this and James
Morris' reported problem, which he reports as "amd64", which presumably
is an x86-64 kernel and not 32 bits... James, is that correct? Any
more details you can give about the system? I *really* don't want to go
into cargo cult programming mode, that would suck eggs no matter what.

-hpa





\
 
 \ /
  Last update: 2010-04-01 01:41    [W:0.100 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site