Messages in this thread | | | Date | Wed, 31 Mar 2010 23:32:39 +0530 (IST) | From | Pavan Savoy <> | Subject | Re: [PATCH] drivers:staging: sources for ST core |
| |
--- On Wed, 31/3/10, Greg KH <gregkh@suse.de> wrote:
> From: Greg KH <gregkh@suse.de> > Subject: Re: [PATCH] drivers:staging: sources for ST core > To: "Pavan Savoy" <pavan_savoy@ti.com> > Cc: "Marcel Holtmann" <marcel@holtmann.org>, alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org > Date: Wednesday, 31 March, 2010, 11:00 PM > On Wed, Mar 31, 2010 at 04:20:22AM > +0530, Pavan Savoy wrote: > > > > --- On Wed, 31/3/10, Pavan Savoy <pavan_savoy@ti.com> > wrote: > > > > > From: Pavan Savoy <pavan_savoy@ti.com> > > > Subject: Re: [PATCH] drivers:staging: sources for > ST core > > > To: gregkh@suse.de > > > Cc: "Marcel Holtmann" <marcel@holtmann.org>, > alan@lxorguk.ukuu.org.uk > > > Date: Wednesday, 31 March, 2010, 4:11 AM > > > --- On Wed, 31/3/10, Pavan Savoy > > > <pavan_savoy@yahoo.co.in> > > > wrote: > > > > > > > From: Pavan Savoy <pavan_savoy@yahoo.co.in> > > > > Subject: Re: [PATCH] drivers:staging: > sources for ST > > > core > > > > To: "pavan_savoy@yahoo.co.in" > > > <pavan_savoy@yahoo.co.in> > > > > Date: Wednesday, 31 March, 2010, 4:06 AM > > > > > From: Greg KH [gregkh@suse.de] > > > > > Sent: Wednesday, March 31, 2010 3:17 > AM > > > > > To: Savoy, Pavan > > > > > Cc: Alan Cox; marcel@holtmann.org; > > > > > linux-kernel@vger.kernel.org > > > > > Subject: Re: [PATCH] drivers:staging: > sources for > > > ST > > > > core > > > > > > > > > > On Wed, Mar 31, 2010 at 02:35:55AM > +0530, Pavan > > > Savoy > > > > > wrote: > > > > > > So, something like the below is > ok, I have > > > > defined my > > > > > own pr_fmt, > > > > > > however default log level on my > board is 7, > > > and > > > > hence > > > > > pr_info is a bit > > > > > > more annoying than usual. > > > > > > > > > > No, a driver should use dev_dbg() and > other > > > > dev_printk() > > > > > calls, not > > > > > pr_debug() or anything like that. > > > > > > > > > > Please don't roll your own formats, use > the ones > > > that > > > > are > > > > > well defined > > > > > and uniquely describe your driver and > device in > > > a > > > > format > > > > > that the whole > > > > > kernel uses. > > > > > > > > > > > forgot lkml the last time.. > > > > Nope, I couldn't find any instance of struct device at > all, > > I need that to use dev_dbg right ? - None of the > tty_* > > structure accessible by ldiscs seems to have a > reference to > > it. > > Also I happened to look at other line discipline > driver, if > > they have a smarter way of doing this, Nope - n_tty, > n_hdlc, > > n_slip all seem to use plain old printks. > > > > Any clues ?? > > Sorry, you are correct, we only have a struct kref right > now for tty > core objects, not a struct device. So nevermind, this > should be fine.
Oh cool. Thanks, So that leaves me with 1 pending item from Alan which is to tie these 3 modules (KIM/Core/LL) up onto a TTY device specific context, and avoid all global ptrs.
So without that is it good to go in ?
> thanks, > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
Your Mail works best with the New Yahoo Optimized IE8. Get it NOW! http://downloads.yahoo.com/in/internetexplorer/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |