lkml.org 
[lkml]   [2010]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH next-next-2.6 v2] virtio_net: missing sg_init_table
    From
    From: "Michael S. Tsirkin" <mst@redhat.com>
    Date: Wed, 31 Mar 2010 12:20:22 +0300

    > On Mon, Mar 29, 2010 at 06:19:15PM -0700, Shirley Ma wrote:
    >> Add missing sg_init_table for sg_set_buf in virtio_net which
    >> induced in defer skb patch.
    >>
    >> Reported-by: Thomas Müller <thomas@mathtm.de>
    >> Tested-by: Thomas Müller <thomas@mathtm.de>
    >> Signed-off-by: Shirley Ma <xma@us.ibm.com>
    >
    > I'm concerned that the 'big' path might cause a performance regression.
    > Let's move sg into virtnet_info so that this needs to be only called
    > once?

    Yeah that might improve things.

    Shirley's change is already in net-next-2.6 so anything implementing
    this would need to be submitted relative to that.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-31 12:19    [W:0.019 / U:1.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site