lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[26/89] nozomi: quick fix for the close/close bug
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Alan Cox <alan@linux.intel.com>

    commit eeec32a731631a9bad9abb21c626b9f2840bee0d upstream.

    Nozomi goes wrong if you get the sequence

    open
    open
    close

    [stuff]
    close

    which turns out to occur on some ppp type setups.

    This is a quick patch up for the problem. It's not really fixing Nozomi
    which completely fails to implement tty open/close semantics and all the
    other needed stuff. Doing it right is a rather more invasive patch set and
    not one that will backport.

    Signed-off-by: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/char/nozomi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/char/nozomi.c
    +++ b/drivers/char/nozomi.c
    @@ -1628,10 +1628,10 @@ static void ntty_close(struct tty_struct

    dc->open_ttys--;
    port->count--;
    - tty_port_tty_set(port, NULL);

    if (port->count == 0) {
    DBG1("close: %d", nport->token_dl);
    + tty_port_tty_set(port, NULL);
    spin_lock_irqsave(&dc->spin_mutex, flags);
    dc->last_ier &= ~(nport->token_dl);
    writew(dc->last_ier, dc->reg_ier);



    \
     
     \ /
      Last update: 2010-03-31 02:29    [W:4.267 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site