lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[033/156] mqueue: fix mq_open() file descriptor leak on user-space processes
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: André Goddard Rosa <andre.goddard@gmail.com>

    commit 4294a8eedb17bbc45e1e7447c2a4d05332943248 upstream.

    We leak fd on lookup_one_len() failure

    Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    ipc/mqueue.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/ipc/mqueue.c
    +++ b/ipc/mqueue.c
    @@ -705,7 +705,7 @@ SYSCALL_DEFINE4(mq_open, const char __us
    dentry = lookup_one_len(name, ipc_ns->mq_mnt->mnt_root, strlen(name));
    if (IS_ERR(dentry)) {
    error = PTR_ERR(dentry);
    - goto out_err;
    + goto out_putfd;
    }
    mntget(ipc_ns->mq_mnt);

    @@ -742,7 +742,6 @@ out:
    mntput(ipc_ns->mq_mnt);
    out_putfd:
    put_unused_fd(fd);
    -out_err:
    fd = error;
    out_upsem:
    mutex_unlock(&ipc_ns->mq_mnt->mnt_root->d_inode->i_mutex);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-31 01:53    [W:4.059 / U:0.452 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site