| Date | Tue, 30 Mar 2010 15:41:00 -0700 | From | Greg KH <> | Subject | [026/156] V4L/DVB (13961): em28xx-dvb: fix memleak in dvb_fini() |
| |
2.6.33-stable review patch. If anyone has any objections, please let us know.
------------------
From: Francesco Lavra <francescolavra@interfree.it>
commit 19f48cb105b7fa18d0dcab435919a3a29b7a7c4c upstream.
this patch fixes a memory leak which occurs when an em28xx card with DVB extension is unplugged or its DVB extension driver is unloaded. In dvb_fini(), dev->dvb must be freed before being set to NULL, as is done in dvb_init() in case of error. Note that this bug is also present in the latest stable kernel release.
Signed-off-by: Francesco Lavra <francescolavra@interfree.it> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/media/video/em28xx/em28xx-dvb.c | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/media/video/em28xx/em28xx-dvb.c +++ b/drivers/media/video/em28xx/em28xx-dvb.c @@ -606,6 +606,7 @@ static int dvb_fini(struct em28xx *dev) if (dev->dvb) { unregister_dvb(dev->dvb); + kfree(dev->dvb); dev->dvb = NULL; }
|