lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[13/45] sit: fix off-by-one in ipip6_tunnel_get_prl
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Sascha Hlusiak <contact@saschahlusiak.de>

    commit 298bf12ddb25841804f26234a43b89da1b1c0e21 upstream.

    When requesting all prl entries (kprl.addr == INADDR_ANY) and there are
    more prl entries than there is space passed from userspace, the existing
    code would always copy cmax+1 entries, which is more than can be handled.

    This patch makes the kernel copy only exactly cmax entries.

    Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
    Acked-By: Fred L. Templin <Fred.L.Templin@boeing.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/ipv6/sit.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv6/sit.c
    +++ b/net/ipv6/sit.c
    @@ -260,7 +260,7 @@ static int ipip6_tunnel_get_prl(struct i

    c = 0;
    for (prl = t->prl; prl; prl = prl->next) {
    - if (c > cmax)
    + if (c >= cmax)
    break;
    if (kprl.addr != htonl(INADDR_ANY) && prl->addr != kprl.addr)
    continue;



    \
     
     \ /
      Last update: 2010-03-31 01:13    [W:4.455 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site