lkml.org 
[lkml]   [2010]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -v2 2/2] genericirq: change ack/mask in irq_chip to take irq_desc instead of irq
    On Wed, 3 Mar 2010, Yinghai Lu wrote:
    > >
    > > The right way to do that is
    > >
    > > 1) add new function pointers, which take irq_desc as their argument
    > >
    > > 2) make the generic code use them when the old function pointer is
    > > NULL
    > >
    > > 3) convert the irq_chip implementations one by one with separate
    > > patches
    > >
    > > 4) Remove the old function pointers and switch the generic code
    > > fully over to use the new ones
    > >
    > > Yes, it's more work, but it's less error prone and easier to review,
    > > as the maintainers just have to look at the patch which affects their
    > > particular area.
    >
    > good. please check if you are happy with this version.

    It's better, but again please provide separate patches for:

    1) the new function pointers

    2) kernel/irq/* making use of them

    3) separate patches for each irq_chip conversion. If several
    chips share the same mask/unmask/etc. functions, then one
    patch for converting those related ones is fine.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2010-03-03 11:33    [W:0.021 / U:1.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site