lkml.org 
[lkml]   [2010]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 1/5] DMAENGINE: COH 901 318 cleanups
Date
From
[Dan Williams]
> On Tue, Mar 2, 2010 at 2:06 PM, Dan Williams
> <dan.j.williams@intel.com> wrote:
> > On Tue, Mar 2, 2010 at 1:12 PM, Linus Walleij
> > <linus.walleij@stericsson.com> wrote:
> >>        if (cohc->nbr_active_done)
> >> +       /*
> >> +        * If another interrupt fired while the tasklet
> was scheduling,
> >> +        * we don't get called twice, so we have this
> number of active
> >> +        * counter that keep track of the number of IRQs
> expected to
> >> +        * be handled for this channel. If there happen to
> be more than
> >> +        * one IRQ to be ack:ed, we simply schedule this
> tasklet again.
> >> +        */
> >>                cohc->nbr_active_done--;
> >
> > Checkpatch made a justifiable wimper about this.  It looks like you
> > wanted to delete that if() according to the previous unified patch?
> >
>
> Looks like it gets deleted later on in patch #3. I took a stab at
> fixing it up[1], or you can just send me a new series if that does not
> look right to you.

That's perfect, thanks Dan. I was splitting the patch up using
some iterative kdiff3 excercises, I just checkpatch.pl:ed the
end result, sorry.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-03-03 10:47    [W:1.514 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site